LogicEditor | Breaking | Refactoring and Redesign
Summary
We used a barebones design for the nodes and had some technical debt, e.g. in form of non-specific naming of nodes and multiple minor bugs.
Problem or need
To improve the readability of Graphs some visual work is needed. Nodes should be compact, color coded and consistent.
Proposed solution
Use UI Toolkit to style the nodes (as well as the backend behind these changes).
ToDo's
A draft of these changes is available at Draft: LogicEditor | Graph Styling and further Changes
in the internal repo.
@s0000118 and @hannah.ploetz: Please coordinate with @nmack if you have time available. If you have, test this branch as much as possible by creating demonstrators and if possible, test all nodes.
Tests should contain:
-
Do nodes persist after saving and loading? In some cases (i could not reproduce) i observed nodes not persisting a save/load. -
Do edges persist after saving and loading? In some cases (i could not reproduce) i observed edges not persisting a save/load. -
Check the nodes Interaction Nodes
andSimple Interaction Nodes
. These seem to be duplicates. -
Check with @nmack if Simple Video (old)
andSimple Audio (old)
can be deleted. -
Test all nodes for functonality -
Test if graphs work with Reroute
nodes -
Test if graphs work with multiple Reroute
nodes chained together
Alternatives considered
N/A
Additional context
Edited by Christian Dominic