Skip to content

LogicEditor | Rename Nodes & Ports in LogicEditor-Module

Summary

Currently, the nodes in the LogicEditor as well as the execution scripts are not named consistently. This reduces the understandability of the code, and further impacts automation of the node creation.

A similar problem exists for the ports and the ActivationActions.

Problem or need

Consistent naming convention for the nodes.

Proposed solution

We introduce a clear convention.

LogicScripts.cs LogicScripts (enum): general purpose name of a node that can act as an identifier. Act -> A node that has an exit port / React -> A node that has an input port beside enable/disable / Field -> Nodes that provide values / Debug -> Nodes for Debuging

ScriptsLookup (dictionary): Auto populate with the names from the enum. (We should add a custom warning here, if we get an item from the dictionary)

UnityNode: [enum]Unity: Bsp: NodeClickAct => Node{Name}Act/React/ActReact

Execution: [enum]: Bsp: ExeClickAct => Exe{Name}Act/React/ActReact

2D: [enum]2D: ActClick2D

3D: [enum]3D: ActClick3D

Namespaces: We need to check and fix the assembly + namespaces

ActivationActions.cs Rework/Rename

ReactionTypes.cs Rework/Rename

PortNameToReactionType We could replace this with a attribute for each port.

Alternatives considered

Have you considered any alternative solutions or features? If so, please describe them.

Additional context

Add any other context or screenshots about the feature request here.

Edited by Alireza